[cuda.compute]: Add tests that depend on the system CTK instead of a pip installed one - #10500
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe CI matrix now defines Python CTK modes
Assessment against linked issues
Suggested reviewers: Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci/test_cuda_cccl_examples_python.sh (1)
31-32: 🩺 Stability & Availability | 🔵 Trivialsuggestion: Run the targeted pinned, latest, and sysctk lanes, including the corresponding minimal/header/compute jobs, and run
pre-commit run --all-files; no GPU/Windows validation results are included here. As per coding guidelines, changes must be validated with relevant builds/tests and pre-commit; as per path instructions, CI scripts should use targeted build/test behavior.Sources: Coding guidelines, Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 734bfd9a-f2a5-4d2d-92aa-b0ec6a938e40
📒 Files selected for processing (14)
.github/actions/workflow-build/build-workflow.pyci/matrix.yamlci/pyenv_helper.shci/test_cuda_cccl_examples_python.shci/test_cuda_cccl_headers_python.shci/test_cuda_compute_minimal_python.shci/test_cuda_compute_python.shci/util/python/common_arg_parser.shci/windows/build_common_python.psm1ci/windows/test_cuda_cccl_examples_python.ps1ci/windows/test_cuda_cccl_headers_python.ps1ci/windows/test_cuda_compute_minimal_python.ps1ci/windows/test_cuda_compute_python.ps1python/cuda_cccl/pyproject.toml
This comment has been minimized.
This comment has been minimized.
848ff7c to
2a1a460
Compare
|
/ok to test d903dc4 |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci/matrix.yaml (1)
149-150: 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy liftimportant: The global exclusion at Lines 451-452 removes every
testjob withmsvc2022, so the fullsysctkrows create no Windows coverage. Thetest_py_compute_minimalrows are not excluded and still requestgpu: 'l4', although the matrix states that Windows GPU runners are unavailable. Use a Windows GPU-capable lane, or remove the unsupported Windows combinations. Apply the same platform rule to both full and minimal sysctk jobs.
ci/matrix.yaml#L149-L150: Correct the pull-request sysctk Windows lane behavior.ci/matrix.yaml#L295-L296: Correct the nightly sysctk Windows lane behavior.ci/matrix.yaml#L392-L393: Correct the weekly sysctk Windows lane behavior.As per path instructions, focus on matrix correctness and GPU availability assumptions.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2c78a346-3dcb-4d73-98a5-4ebd20f46fb0
📒 Files selected for processing (1)
ci/matrix.yaml
⏱️ CCCL compile-time benchmark comparison: Public headers compile-time benchResult: 1 regression row(s), 10 improvement row(s) above threshold.
Artifacts: reports and traces TU total compilation
🟢 TU total compilation — Improvements
Direct file processing
🔴 Direct file processing — Regressions
🟢 Direct file processing — Improvements
|
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 7h 40m: Pass: 100%/534 | Total: 17d 14h | Max: 2h 37m | Hits: 35%/1944623See results here. |
…pip installed one (NVIDIA#10500)
Description
closes #10060
Checklist