Jm/bio 713 mxfp8 enum member#285
Merged
Merged
Conversation
Mirror MXFP8/BFLOAT16 into the fallback TriMulPrecision enum so precision=TriMulPrecision.MXFP8 resolves whether or not the cuequivariance_ops_torch backend is installed. Document the MXFP8 option in the triangle_multiplicative_update docstring as opt-in, inference-only, seq % 32 == 0, Blackwell-only (cc >= 10.0), with transparent bf16 fallback. Add frontend tests: an always-on enum-member check and a GPU-guarded MXFP8 inference exercise (string + enum paths). Default stays precision=None (off); MXFP8 backward is not yet implemented. Signed-off-by: Jonathan Mitchell <jomitchell@nvidia.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Carry forward the BIO-713 review change: the fallback TriMulPrecision enum mirrors the backend sentinels, which moved from -1000/-1001 to the sequential enum values 4/5. Update the enum-member test assertions to match. Signed-off-by: Jonathan Mitchell <jomitchell@nvidia.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
trvachov
approved these changes
Jun 4, 2026
jomitchellnv
added a commit
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #
Checklist
Please confirm the following before requesting review. PRs that do not meet these requirements cannot be merged. See CONTRIBUTING.md for the full contribution rules.
Contribution rules
pre-commitlocally (pip install pre-commit && pre-commit install).[WIP].Sign-off (DCO)
Per Signing Your Work, every commit in this PR must be signed off with
git commit -s(appendingSigned-off-by: Your Name <your@email.com>). PRs containing unsigned commits will not be accepted.git commit -s).