ci: skip multi-arch manifest publish when push is disabled#2485
Open
fallintoplace wants to merge 1 commit into
Open
ci: skip multi-arch manifest publish when push is disabled#2485fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push_on_buildisfalseWhy
The per-arch image builds already honor
push_on_buildthrough the build output settings, but the final manifest job still runs unconditionally.That leaves us with an inconsistent flow in non-push contexts: the workflow can skip pushing the arch images and then still try to create and push a multi-arch manifest that references images that were never published.
This showed up after the CI workflow split introduced
push_on_buildinto the modular workflows, but the manifest job never started consuming that signal.Validation
git diff --checkruby -e 'require "yaml"; YAML.load_file(".github/workflows/image-builds.yaml")'I did not run the workflow end-to-end locally.