chore: add integration tests for expected power shelves and switches#844
Open
chet wants to merge 1 commit intoNVIDIA:mainfrom
Open
chore: add integration tests for expected power shelves and switches#844chet wants to merge 1 commit intoNVIDIA:mainfrom
chet wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-04-08 00:10:48 UTC | Commit: 0969fbd |
poroh
approved these changes
Apr 8, 2026
I recently did NVIDIA#842 to fix an issue with expected power shelf ingestion, and wanted to put together an integration test for it. While I was doing that, I realized it might be nice to have equivalent tests for switches and power shelves, and figured I'd do it as a separate PR. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
chet
force-pushed
the
power_shelf_switch_ingestion_integration_tests
branch
from
0969fbd to
5c0aed6
Compare
poroh
approved these changes
Apr 8, 2026
Matthias247
reviewed
Apr 8, 2026
| let client = build_api_client(test_env); | ||
|
|
||
| // Create a Lite-On power shelf BMC mock. HostMachineInfo::new generates a unique MAC address. | ||
| let host_info = bmc_mock::HostMachineInfo::new(HostHardwareType::LiteOnPowerShelf, vec![]); |
Contributor
There was a problem hiding this comment.
Oh boy, this is bmc-mock naming failure. What is right term that joins switches powershelves and host machines?
Matthias247
reviewed
Apr 8, 2026
Contributor
Matthias247
left a comment
Matthias247
left a comment
There was a problem hiding this comment.
this is ok. But we also should have equivalents of env.create_managed_host() for switches and powershelves that do all of this behind the scenes. Most tests would be using these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I recently did #842 to fix an issue with expected power shelf ingestion, and wanted to put together an integration test for it. While I was doing that, I realized it might be nice to have equivalent tests for switches and power shelves, and figured I'd do it as a separate PR.
Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes