Fix resource leak for KaggleWebServiceClient missing a close call. - #20
Open
sngraam wants to merge 1 commit into
Open
Fix resource leak for KaggleWebServiceClient missing a close call.#20sngraam wants to merge 1 commit into
sngraam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[fetch_leaderboard_writeups.py, fetch_writeup.py]What changed:
- wrapped
kaggle_web_service()call in awithcontext manager block.- moved
_resolve_topic_idexecution within the same context block.[archive.py]within
try...finally blocks.code now dynamically monitors if a local client was created inside the function(is_local_client = client is None)and ensures that client.close()