perftest: fix reducescatter latency size reporting#93
Open
jasha64 wants to merge 1 commit into
Open
Conversation
Avoid shadowing num_elems in for loop so the timed kernel launches use the current message size instead of repeatedly measuring the initial element count. Signed-off-by: jasha64 <yijunma@student.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes incorrect device reducescatter perftest results caused by RUN_ITERS_OP declaring a loop-local num_elems after the kernel argument lists had already captured the outer variable. The benchmark was printing increasing message sizes while repeatedly timing the initial element count, which produced nearly constant latencies and inflated bandwidth values. Reusing the existing num_elems keeps the kernel arguments, size table, and reported metrics in sync.
Previously, running this reducescatter_latency perftest will report extraordinarily large bandwidth. Fixed in this pull request.