fix(user_tools): download explicit tools jar#2108
Draft
WilliamK112 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--tools_jarvalues even when the packaged tools jar is available locallygs://tools jarRoot cause
When
use_local_tools_jar()is true,_process_jar_arg()used the jar path directly without checking whether the user had supplied--tools_jar. That lets a remote jar URL flow into the Java classpath unchanged, which causes Java to fail loading the tools main class.Fixes #1889
Validation
.venv/bin/python -m pytest tests/spark_rapids_tools_ut/test_path_boundary.py -q.venv/bin/python -m flake8 tests/spark_rapids_tools_ut/test_path_boundary.py src/spark_rapids_pytools/rapids/rapids_tool.py.venv/bin/python -m pylint -d fixme --load-plugins pylint_pydantic --rcfile=../.pylintrc tests/spark_rapids_tools_ut/test_path_boundary.py src/spark_rapids_pytools/rapids/rapids_tool.pygit diff --checkNote:
test_tool_argprocessor.pywas also attempted locally, but the local macOS environment is missinglibomp.dylib, so unrelated XGBoost imports fail before these changes are exercised.