Skip to content

fix(user_tools): download explicit tools jar#2108

Draft
WilliamK112 wants to merge 1 commit into
NVIDIA:devfrom
WilliamK112:codex/download-explicit-tools-jar
Draft

fix(user_tools): download explicit tools jar#2108
WilliamK112 wants to merge 1 commit into
NVIDIA:devfrom
WilliamK112:codex/download-explicit-tools-jar

Conversation

@WilliamK112

Copy link
Copy Markdown

Summary

  • download explicitly supplied --tools_jar values even when the packaged tools jar is available locally
  • keep the direct local-resource fast path only for the default wheel-provided jar
  • add unit coverage for the default local-resource jar path and an explicit remote gs:// tools jar

Root cause

When use_local_tools_jar() is true, _process_jar_arg() used the jar path directly without checking whether the user had supplied --tools_jar. That lets a remote jar URL flow into the Java classpath unchanged, which causes Java to fail loading the tools main class.

Fixes #1889

Validation

  • .venv/bin/python -m pytest tests/spark_rapids_tools_ut/test_path_boundary.py -q
  • .venv/bin/python -m flake8 tests/spark_rapids_tools_ut/test_path_boundary.py src/spark_rapids_pytools/rapids/rapids_tool.py
  • .venv/bin/python -m pylint -d fixme --load-plugins pylint_pydantic --rcfile=../.pylintrc tests/spark_rapids_tools_ut/test_path_boundary.py src/spark_rapids_pytools/rapids/rapids_tool.py
  • git diff --check

Note: test_tool_argprocessor.py was also attempted locally, but the local macOS environment is missing libomp.dylib, so unrelated XGBoost imports fail before these changes are exercised.

Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
@github-actions github-actions Bot added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CLI errors out when using Remote URL for Tools JAR

2 participants