Skip to content

fix: argparse type=bool cannot parse False from command line - #51

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/replay-dc280e95
Open

fix: argparse type=bool cannot parse False from command line#51
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/replay-dc280e95

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in scripts/replay.py: argparse type=bool cannot parse False from command line.

Changes

  • scripts/replay.py: argparse type=bool cannot parse False from command line.

Details

Before:

    parser.add_argument("--rgb_enabled", type=bool, default=True)
    parser.add_argument("--segmentation_enabled", type=bool, default=True)
    parser.add_argument("--depth_enabled", type=bool, default=True)
    parser.add_argument("--instance_id_segmentation_enabled", type=bool, default=True)
    parser.add_argument("--normals_enabled", type=bool, default=False)

After:

    def _str_to_bool(value):
        if isinstance(value, bool):
            return value
        if value.lower() in ("yes", "true", "t", "y", "1"):
            return True
        if value.lower() in ("no", "false", "f", "n", "0"):
            return False
        raise argparse.ArgumentTypeError("Boolean value expected.")

    parser.add_argument("--rgb_enabled", type=_str_to_bool, default=True)
    parser.add_argument("--segmentation_enabled", type=_str_to_bool, default=True)
    parser.add_argument("--depth_enabled", type=_str_to_bool, default=True)
    parser.add_argument("--instance_id_segmentation_enabled", type=_str_to_bool, default=True)
    parser.add_argument("--normals_enabled", type=_str_to_bool, default=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant