Persist attachment state per record during sync passes#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the attachment syncing pipeline to reduce lock contention by narrowing the scope of the attachment-context mutex and persisting progress incrementally, so large queues don’t block other queue operations and completed transfers aren’t lost on interruption.
Changes:
- Refactors
RunSyncPassAsyncto acquire the attachment context only for table reads/writes, not for the entire sync pass. - Updates
ProcessAttachmentsAsyncto persist each attachment state change immediately after its transfer completes. - Updates
DeleteAttachmentAsyncto perform DB deletion viaWithContextAsyncinternally instead of requiring a context parameter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
133
to
+143
| Attachment? changed = attachment.State switch | ||
| { | ||
| AttachmentState.QueuedUpload => await UploadAttachmentAsync(attachment), | ||
| AttachmentState.QueuedDownload => await DownloadAttachmentAsync(attachment), | ||
| AttachmentState.QueuedDelete => await DeleteAttachmentAsync(attachment, context), | ||
| AttachmentState.QueuedDelete => await DeleteAttachmentAsync(attachment), | ||
| _ => null, | ||
| }; | ||
|
|
||
| if (changed is not null) | ||
| { | ||
| updates.Add(changed); | ||
| await attachmentService.WithContextAsync(ctx => ctx.SaveAttachmentsAsync([changed])); |
| } | ||
|
|
||
| await context.DeleteAttachmentAsync(attachment.Id); | ||
| await attachmentService.WithContextAsync(ctx => ctx.DeleteAttachmentAsync(attachment.Id)); |
Comment on lines
+118
to
+120
| var active = await attachmentService.WithContextAsync(ctx => ctx.GetActiveAttachmentsAsync()); | ||
| await ProcessAttachmentsAsync(active); | ||
| await attachmentService.WithContextAsync(ctx => DeleteArchivedAttachmentsAsync(ctx)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunSyncPassAsyncheld the attachment context mutex for the entire pass and saved all state changes in one batch at the end. On a large queue, a single pass starved every other queue operation for its duration, plus any interruption discarded the progress of every completed transfer.The context is now acquired only for table reads and writes, and each attachment is persisted as soon as its transfer completes, matching the JS & Dart helpers.