Add Amazon PR/FAQ review handoff - #89
Open
followdon wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A clean Ringer delivery could reach the human review gate without a customer-led explanation of what changed, and an already-merged PR could be mistaken for a blocked current handoff. That made the final review package manual and made lifecycle language easy to overstate.
What changed
amazon-pr-faqskill with an Amazon Working Backwards template and deterministic evidence validator.review_handoffis the safe default and produces exactlyREADYorBLOCKED.retrospectiveis explicit and recordsBuilt,Merged,Deployed, andAvailableseparately for historicalMERGEDorCLOSEDPRs.$amazon-pr-faqinreview_handoffmode. READY requires worker gates, full repository gates, fresh independent review, matching local/remote/GitHub head SHAs, mergeability, and successful required checks for the same commit. A later commit invalidates the package.@followdonfor the Amazon PR/FAQ handoff contribution.Safety and authorization
The hook never pushes, creates or updates a PR, writes a PR body/comment, merges, or deploys merely to satisfy its gate. Missing authorization or evidence produces a BLOCKED package. The workflow stops at the human merge/deploy decision.
Verification
02d00fa878a0bbde01a77df081268cdd3cab56ec:RINGER_HOME=/private/tmp/ringer-final-strict-exact-gates RINGER_NO_SELF_UPDATE=1 python3 -m unittest discover -s tests— 263 tests passed.RINGER_NO_SELF_UPDATE=1 python3 -m unittest tests.test_agent_install tests.test_amazon_pr_faq— 15 focused tests passed.python3 .claude/skills/amazon-pr-faq/scripts/validate_pr_faq.py --self-test— 8 valid scenarios accepted and 50 bad cases rejected.02d00fa878a0bbde01a77df081268cdd3cab56ec— no actionable findings; 33 adversarial cases and the 263-test isolated suite passed.git diff --check— passed.No merge, deployment, or production operation is part of this PR.