fix: ensure dex cache directory exists before proxy generation#1938
Open
NathanWalker wants to merge 1 commit intomainfrom
Open
fix: ensure dex cache directory exists before proxy generation#1938NathanWalker wants to merge 1 commit intomainfrom
NathanWalker wants to merge 1 commit intomainfrom
Conversation
Harden dex directory setup in RuntimeHelper with existence check and fallback to files/secondary-dexes when code_cache is unavailable. Add defensive parent directory creation in ProxyGenerator.saveProxy() to prevent ENOENT crashes on newer Android versions.
triniwiz
approved these changes
Apr 9, 2026
Contributor
Author
|
Tagged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkdirs(), falling back tofiles/secondary-dexesifcode_cache/secondary-dexesis unusablemkdirs()inProxyGenerator.saveProxy()beforecreateNewFile()as a safety netContext
ProxyGenerator.saveProxy()callsFile.createNewFile()which fails with ENOENT when the parent directory is missing. The runtime constructs the dex cache path manually (<dataDir>/code_cache/secondary-dexes) rather than usingContext.getCodeCacheDir(), and whileDexFactorycallsmkdirs()at init time, it never checks the return value.On newer Android versions (API 28+), the OS can clear
code_cacheto reclaim storage, and stricter permission models can causemkdirs()to silently fail. This was always fragile but rarely triggered on older Android versions wherecode_cachewas reliably present.