Replace direct uses of weld() with tool interactions - #5401
Open
out-of-phaze wants to merge 26 commits into
Open
out-of-phaze wants to merge 26 commits into
out-of-phaze wants to merge 26 commits into
Conversation
out-of-phaze
added
the
work in progress
out-of-phaze
force-pushed
the
codequality/weld_interact
branch
2 times, most recently
from
August 8, 2026 00:49
641871c to
a6b185f
Compare
out-of-phaze
force-pushed
the
codequality/weld_interact
branch
from
September 3, 2026 02:44
a6b185f to
b15a5af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this one is a doozy
replaces a lot of direct uses of weld() with tool interactions, some others with just the welder tool archetype checks (mostly ones that had messages i couldn't convert, or other checks during/after)
also makes a few other interactions use tool interactions, mostly on airlocks i think
entirely untested atm
i might split this up into easier to review PRs. not one commit each though that would be awful, more like atmos pipes and machines / disposals machines and pipes / airlocks + firedoors + door assemblies / closets / crafting step / demolisher extension / machine frames / airlock braces / rod + shard / lattice + plating / robots / field generator + spiderling + self-destruct.
emitters intentionally excluded, they are already covered by #5335