Replace most uses of decl text-refs with UIDs - #5420
Draft
out-of-phaze wants to merge 29 commits into
Draft
out-of-phaze wants to merge 29 commits into
out-of-phaze wants to merge 29 commits into
Conversation
out-of-phaze
added
the
work in progress
out-of-phaze
force-pushed
the
codequality/decl_href
branch
from
August 27, 2026 00:14
98de556 to
498bc20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replaces a lot of uses of
locate()and\ref[]on/decls with UIDs. Also adds UIDs to a lot of these types.Leaves a few, namely the ones covered in #5411, language ones that I expect to conflict with #5271, and supply packs (because there's hundreds of them).
Why and what will this PR improve
We should use UIDs for these. Also simplifies some serialization.
Authorship
me