Adjust generate_z_connections wraparound check - #5427
Draft
out-of-phaze wants to merge 1 commit into
Draft
out-of-phaze wants to merge 1 commit into
out-of-phaze wants to merge 1 commit into
Conversation
out-of-phaze
added
the
work in progress
out-of-phaze
force-pushed
the
fix/zconn-wraparound
branch
from
September 3, 2026 01:11
ef22697 to
0437458
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
we have to check adjacency (via x/y) instead of just z level. due to how the x and y of corners work this might need to check if the distance is > 0.5 (yuck floating point error) instead of > 1 but i'm not sure
Why and what will this PR improve
fixes an issue that sometimes(?) happens on planet testing, not sure why it wouldn't always happen
Authorship
me