Add #[serde(flatten)] to Transformer enum - #42
Draft
NelsonAPenn wants to merge 3 commits into
Draft
Conversation
NelsonAPenn
force-pushed
the
feature/flatten-transformer
branch
from
August 20, 2026 03:32
52bf24e to
3b2eebc
Compare
This is a breaking change, but has an outsized impact on the simplicity of the config file.
NelsonAPenn
force-pushed
the
feature/flatten-transformer
branch
from
August 20, 2026 04:33
ef29f08 to
c873d59
Compare
Owner
Author
|
One other thing I'm worried about is how much the transformer enum variants with options differ from those without in the TOML file. It prevents from using a consistent table format for defining transformers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change, but has an outsized impact on the simplicity of the config file.
This is one step towards #37 . Is this on its own enough?