Fix Vision Prediction, add vision off sound and separate sound channel for vision sounds. Also fix ghost pickup sound not playing on its own special channel

[AdamTadeusz]

Description

-----> EPILEPSY WARNING <------

Makes toggling the vision mode far smoother at high ping.

Recommend testing through the following:

bind mwheeldown +vision
test how quickly the vision mode can be triggered on a listen server and pay attention to the sound
then
net_fakelag 200
and do the same

also notice how individual inputs at high ping also don't cause the screen to flicker multiple times

Toolchain

• Windows MSVC VS2022

Linked Issues

• fixes toggling vision mode should be smooth at high ping #2042
• fixes The Ghost pickup sound should play on its own channel so it doesn't get overriden by any other sound #2043

[AdamTadeusz]

I added the tournament priority label since this also fixed the ghost pickup sound not playing on its own channel. If need be I can move this fix to a separate PR

[AdamTadeusz]

also this stops C_NEO_Player::PreDataUpdate returning early before calling the base class that does some important things so thats also important for the tourney

[sunmachine]

Leaving these as comments for now. Reading more tonight. I feel I'm still really trying to get a handle on this ahead of asking y'all questions as a point of self-exercise. The static stuff was easy to figure out at least.

The other thing I'm trying to figure out, too, is whether this should be two PRs? I can see a world where we need to do a revert for one of the things changed in this, but we'd need to pull out perfectly fine refactoring (so far as I can tell 👀) as a result.

[sunmachine]

Solid PR. Good refactor.

I have a broader question about supposedly dead imports my compiler is warning me about, but that's not only affecting this PR, and its for chat (e.g. how worried are we about transitive dependencies from unused imports)?