Validate marker labels against their scopes - #419
Open
Pybsama wants to merge 2 commits into
Open
Conversation
Validate marker labels using the permitted values for the computed 2013, 2016, or 2020 standard scope. Warn for custom scopes and restore the 2013 schema default.
Only validate marker labels on actual marker virtual tracks. Add a regression for a schema-valid but unsupported TrackFileResourceType in a MarkerSequence so validation reports the existing empty-resource error instead of throwing ClassCastException.
Pybsama
marked this pull request as ready for review
August 28, 2026 21:04
Author
|
This is now ready for review. A follow-up edge-case review found that a schema-valid but unsupported Fresh verification on the published tree:
The existing fork workflow run remains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
./gradlew build./gradlew --rerun-tasks test --tests com.netflix.imflibrary.validation.IMFCPLValidatorTestgit diff --checkCloses #394