Skip to content

Avoid importing collections from typing#139

Merged
akaIDIOT merged 2 commits intomainfrom
bugfix/avoid-import-collections-typing
Feb 21, 2026
Merged

Avoid importing collections from typing#139
akaIDIOT merged 2 commits intomainfrom
bugfix/avoid-import-collections-typing

Conversation

@akaIDIOT
Copy link
Copy Markdown
Member

Some ruff rules would trigger, some wouldn't, hopefully this makes things better.

@github-actions
Copy link
Copy Markdown

Comparing median (lower is better) metric of benchmarks between this PR's target (042dc11) and the HEAD of this PR (82d1fcb):

3.10 3.11 3.12 3.13 3.14 PyPy 3.10 PyPy 3.11
test_benchmark_get +1% +1% -1% -3% -6% +11% +2%
test_benchmark_get_dotted +2% +3% -3% -5% +0% +5% -1%
test_benchmark_getattr -0% +1% -1% -6% -9% +12% -4%
test_benchmark_getitem -0% +1% -1% -2% -6% +11% -3%
test_benchmark_getitem_dotted +1% +4% -1% -2% -2% +8% -1%
test_benchmark_init_full_overlap -0% +2% +1% -1% -1% -1% -1%
test_benchmark_init_no_overlap +1% +3% -0% -1% -3% -5% -0%
test_benchmark_init_partial_overlap -0% +2% -0% -2% -2% +0% -2%
test_benchmark_reference_chain -2% -1% -1% +1% -1% +12% +1%
test_benchmark_splat_args +0% +1% -0% +0% -2% +30% +1%
test_benchmark_spread_kwargs -1% -1% -3% +0% -5% +10% -2%

(This comment will be updated on subsequent pushes)

@akaIDIOT akaIDIOT merged commit 044f827 into main Feb 21, 2026
9 checks passed
@akaIDIOT akaIDIOT deleted the bugfix/avoid-import-collections-typing branch February 21, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant