Fix Yul block execution after control-flow checkpoints - #85
Open
smoelius wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was found by Codex, and the PR was produced by Codex.
This PR fixes Yul block execution so that a block stops evaluating subsequent
statements once a statement produces a non-normal control-flow state, such as
the state produced by
break,continue, orleave.Previously,
execcontinued executing the rest of a.Blockafter anysuccessful
Except.okresult, even if the returned Yul state was a control-flowstate rather than a normal
.Okstate. That meant a block like:{ break let x := 1 }would continue into
let x := 1afterbreak, instead of stopping at the breakstate.
The block execution case now continues only when the intermediate state is
.Ok; otherwise it returns the checkpoint state unchanged.Testing
Added
EvmYul.Yul.InterpreterTests.exec_block_stops_after_break, which checksthat:
{ break let x := 1 }evaluates to
.Checkpoint (.Break ...)without executing the laterlet.Tested with: