Reset demo recorder state after saving - #62
Open
eust-w wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
DemoRecorder.save_demo clears the active demo after a successful write but currently leaves is_recording set to true. A subsequent record call is then ignored, leaving the recorder in an inconsistent state with no active demo. The next timestep can fail because it is sent to None.
The recorder should become idle only after a successful save. A failed save should continue to propagate while retaining the active recording for retry.
Compatibility
The common record, stop, save sequence is unchanged. This only fixes the state of callers that save directly while recording and makes the returned path follow Demo.save.
Validation
Supersedes #57 after the source branch was renamed to remove the agent/ prefix.