Load only requested demos during fallback conversion - #64
Open
eust-w wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When the requested frequency or observation mode is not cached,
DemoStorecurrently loads every source demo before applying
amount. Long-horizon pixeldemonstrations can therefore exhaust memory even when the caller requests only
one or two episodes.
Applying the existing limit to paths first bounds deserialization and conversion
work by the requested amount without changing the public API or output type.
Compatibility
Negative
amountvalues still load all demos, zero still returns immediately,requests larger than the available archive still raise
TooManyDemosRequestedError, and positive requests retain random selection.Validation
pre-commit run --files demonstrations/demo_store.py tests/test_demo_store.py CHANGELOG.mdpytest -q tests/test_demo_store.py(13 passed)git diff --checkSupersedes #59 after the source branch was renamed to remove the agent/ prefix.