Support configurable camera FOV and large observations - #65
Open
eust-w wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CameraConfigobservation camera requests a larger resolution
default 640-pixel framebuffer
Why
Camera position and orientation are configurable, but field of view currently
is not. In addition,
mujoco.Rendererrejects observation widths or heightslarger than
model.vis.global_.offwidthoroffheight; the default width istypically 640, so common camera modes such as 848-pixel RGB fail during
environment initialization.
Sizing the framebuffer from the configured cameras keeps existing defaults for
small observations while allowing larger camera streams without requiring XML
changes.
Compatibility
fovyis optional and existing camera metadata remains valid. The framebufferonly grows when required and is set before both BiGym and observation renderers
are initialized.
Validation
pre-commit run --files bigym/utils/observation_config.py bigym/bigym_env.py tests/test_observations.py CHANGELOG.mdpytest -q tests/test_observations.py(12 passed)git diff --checkSupersedes #60 after the source branch was renamed to remove the agent/ prefix.