Skip to content

FIX #408 Hide location row when no location @ashishxdev #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashishxdev wants to merge 4 commits into from
Closed

FIX #408 Hide location row when no location @ashishxdev #430

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e608a67
FIX #408 Hide location row when no location
ashishxdev Apr 4, 2026
3fe80e9
fix #408 hide location row when no location
ashishxdev Apr 4, 2026
363751d
fix #408 hide location icon and row when location is empty or whitespace
ashishxdev Apr 4, 2026
7536165
Merge branch 'main' into fix/dont-show-location
ashishxdev Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion src/_includes/bio.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,14 @@
</div>

<div class="space-y-4 text-sm border-t border-[var(--border-color)] pt-6">
{% if location %}
<div class="flex items-center gap-3">
<span class="text-lg">📍</span>
<span class="text-[var(--text-muted)]">{{ location }}{% if country %}, {{ country }}{% endif %}</span>
<span class="text-[var(--text-muted)]">
{% if location and country %}{{ location }}, {{ country }}{% elif location %}{{ location }}{% endif %}
</span>
</div>
{% endif %}
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for displaying the location has been made unnecessarily complex and introduces potential UI issues due to whitespace handling.

  1. Redundancy: The nested if/elif checks for location are redundant because the entire block is already guarded by {% if location %}. The previous logic was more concise and readable.
  2. Whitespace Sensitivity: In HTML, newlines and indentation inside a <span> are rendered as spaces. The current multi-line structure will likely result in unwanted leading and trailing whitespace around the location text.
  3. Consistency: It is recommended to use | trim to ensure that strings containing only whitespace are correctly identified as empty, matching the logic applied in src/index.njk.
            {% if location and location | trim %}
            <div class="flex items-center gap-3">
              <span class="text-lg">📍</span>
              <span class="text-[var(--text-muted)]">{{ location }}{% if country %}, {{ country }}{% endif %}</span>
            </div>
            {% endif %}

Copy link
Copy Markdown
Member

@BaseMax BaseMax Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, please fix it.


{% if email %}
<div class="flex items-center gap-3 group cursor-pointer" onclick="copyToClipboard('{{ email }}', this)">
Expand Down
2 changes: 1 addition & 1 deletion src/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ layout: false
<p class="text-accent font-semibold text-sm uppercase tracking-wider">{{ person.data.role }}</p>
</div>
{% set location = person.data.location %}
{% if location %}
{% if location and location | trim %}
<span class="shrink-0 text-[10px] bg-[var(--bg-footer)] text-[var(--text-muted)] px-2 py-1 rounded font-bold uppercase border border-[var(--border-color)]">
{{ location }}
</span>
Expand Down