Skip to content

[Chapter 8] Notation inconsistency in RoPE formula (variable t vs i) (Page 60) #10

Description

@Sameta-cani

Location

  • File: chapters/nlp-book-chapter8.pdf
  • Page: 60
  • Section: 8.3.5.3 Rotary Positional Embedding

Problem Description
I found a notation inconsistency in the description of Rotary Positional Embeddings (RoPE).
In the text, the position is defined as $t$ ("When reaching position $t$..."); however, the formula uses $i$ inside the rotation term ( $\text{Ro}(\mathbf{x}, i\theta)$ ).

Suggested Fix
To maintain consistency with the text context, the variable in the formula should be updated from $i$ to $t$.

  • Current: $\text{Ro}(\mathbf{x}, i\theta)$
  • Correction: $\text{Ro}(\mathbf{x}, t\theta)$

This clarifies that the rotation depends on the position $t$.

Thank you!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions