Merge pull request #1619 from Northeastern-Electric-Racing/#1096-workpackage-leads-add-tasks

#1096 work package leads can create tasks

Author: RChandler234

src/backend/src/services/tasks.services.ts

@@ -37,7 +37,11 @@ export default class TasksService {
   ): Promise<Task> {
     const requestedWbsElement = await prisma.wBS_Element.findUnique({
       where: { wbsNumber: wbsNum },
-      include: { project: { include: { teams: { ...teamQueryArgs }, wbsElement: true } } }
+      include: {
+        project: {
+          include: { teams: { ...teamQueryArgs }, wbsElement: true, workPackages: { include: { wbsElement: true } } }
+        }
+      }
     });
     if (!requestedWbsElement) throw new NotFoundException('WBS Element', wbsPipe(wbsNum));
     if (requestedWbsElement.dateDeleted) throw new DeletedException('WBS Element', wbsPipe(wbsNum));
@@ -51,9 +55,23 @@ export default class TasksService {
     const isProjectLeadOrManager =
       createdBy.userId === requestedWbsElement.projectLeadId || createdBy.userId === requestedWbsElement.projectManagerId;
 
-    if (!isLeadership(createdBy.role) && !isProjectLeadOrManager && !teams.some((team) => isUserOnTeam(team, createdBy))) {
+    const curWorkPackages = project.workPackages;
+
+    const isWorkPackageLeadOrManager = curWorkPackages.some((workPackage) => {
+      return (
+        workPackage.wbsElement.projectLeadId === createdBy.userId ||
+        workPackage.wbsElement.projectManagerId === createdBy.userId
+      );
+    });
+
+    if (
+      !isLeadership(createdBy.role) &&
+      !isProjectLeadOrManager &&
+      !isWorkPackageLeadOrManager &&
+      !teams.some((team) => isUserOnTeam(team, createdBy))
+    ) {
       throw new AccessDeniedException(
-        'Only admins, app-admins, project leads, project managers, or current team users can create tasks'
+        'Only admins, app-admins, project leads, project managers, work package leads, work package managers, or current team users can create tasks'
       );
     }
 

src/backend/tests/tasks.test.ts

@@ -63,7 +63,7 @@ describe('Tasks', () => {
         TasksService.createTask(theVisitor, mockWBSNum, 'hellow world', '', mockDate, 'HIGH', 'DONE', [])
       ).rejects.toThrow(
         new AccessDeniedException(
-          'Only admins, app-admins, project leads, project managers, or current team users can create tasks'
+          'Only admins, app-admins, project leads, project managers, work package leads, work package managers, or current team users can create tasks'
         )
       );
 

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/TaskList/TaskList.tsx

@@ -66,9 +66,14 @@ const TaskList = ({ project }: TaskListProps) => {
   const { user } = auth;
   if (!user) return <LoadingIndicator />;
 
+  const isWorkPackageLeadOrManager = project.workPackages.some((workPackage) => {
+    return workPackage.projectLead?.userId === user.userId || workPackage.projectManager?.userId === user.userId;
+  });
+
   const createTaskPermissions =
     isLeadership(user.role) ||
     project.projectLead?.userId === user.userId ||
+    isWorkPackageLeadOrManager ||
     project.projectManager?.userId === user.userId ||
     project.teams.some((team) => team.head.userId === user.userId) ||
     project.teams.some((team) => team.leads.map((lead) => lead.userId).includes(user.userId));