Work package managers can also create tasks

Author: msereeyothin

src/backend/src/services/tasks.services.ts

@@ -57,18 +57,21 @@ export default class TasksService {
 
     const curWorkPackages = project.workPackages;
 
-    const isWorkPackageLead = curWorkPackages.some((workPackage) => {
-      return workPackage.wbsElement.projectLeadId === createdBy.userId;
+    const isWorkPackageLeadOrManager = curWorkPackages.some((workPackage) => {
+      return (
+        workPackage.wbsElement.projectLeadId === createdBy.userId ||
+        workPackage.wbsElement.projectManagerId === createdBy.userId
+      );
     });
 
     if (
       !isLeadership(createdBy.role) &&
       !isProjectLeadOrManager &&
-      !isWorkPackageLead &&
+      !isWorkPackageLeadOrManager &&
       !teams.some((team) => isUserOnTeam(team, createdBy))
     ) {
       throw new AccessDeniedException(
-        'Only admins, app-admins, project leads, project managers, work package leads, or current team users can create tasks'
+        'Only admins, app-admins, project leads, project managers, work package leads, work package managers, or current team users can create tasks'
       );
     }
 

src/backend/tests/tasks.test.ts

@@ -63,7 +63,7 @@ describe('Tasks', () => {
         TasksService.createTask(theVisitor, mockWBSNum, 'hellow world', '', mockDate, 'HIGH', 'DONE', [])
       ).rejects.toThrow(
         new AccessDeniedException(
-          'Only admins, app-admins, project leads, project managers, work package leads, or current team users can create tasks'
+          'Only admins, app-admins, project leads, project managers, work package leads, work package managers, or current team users can create tasks'
         )
       );
 

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/TaskList/TaskList.tsx

@@ -66,14 +66,14 @@ const TaskList = ({ project }: TaskListProps) => {
   const { user } = auth;
   if (!user) return <LoadingIndicator />;
 
-  const isWorkPackageLead = project.workPackages.some((workPackage) => {
-    return workPackage.projectLead?.userId === user.userId;
+  const isWorkPackageLeadOrManager = project.workPackages.some((workPackage) => {
+    return workPackage.projectLead?.userId === user.userId || workPackage.projectManager?.userId === user.userId;
   });
 
   const createTaskPermissions =
     isLeadership(user.role) ||
     project.projectLead?.userId === user.userId ||
-    isWorkPackageLead ||
+    isWorkPackageLeadOrManager ||
     project.projectManager?.userId === user.userId ||
     project.teams.some((team) => team.head.userId === user.userId) ||
     project.teams.some((team) => team.leads.map((lead) => lead.userId).includes(user.userId));