#1509 fixed tests

Author: jackturner106

src/backend/src/services/projects.services.ts

@@ -623,14 +623,6 @@ export default class ProjectsService {
     if (!isProject(wbsNumber)) throw new HttpException(400, `${wbsPipe(wbsNumber)} is not a valid project WBS #!`);
     const { carNumber, projectNumber, workPackageNumber } = wbsNumber;
 
-    const checkAssembly = await prisma.assembly.findUnique({
-      where: {
-        name
-      }
-    });
-
-    if (checkAssembly) throw new HttpException(400, `${name} already exists as an assembly!`);
-
     const project = await prisma.project.findFirst({
       where: {
         wbsElement: {
@@ -645,6 +637,10 @@ export default class ProjectsService {
     if (!project) throw new NotFoundException('Project', wbsPipe(wbsNumber));
     if (project.wbsElement.dateDeleted) throw new DeletedException('Project', project.projectId);
 
+    const checkAssembly = await prisma.assembly.findUnique({ where: { name } });
+
+    if (checkAssembly) throw new HttpException(400, `${name} already exists as an assembly!`);
+
     const { teams, wbsElementId } = project;
 
     if (!isAdmin(userCreated.role) && !isUserPartOfTeams(teams, userCreated))

src/backend/tests/projects.test.ts

@@ -301,7 +301,6 @@ describe('Projects', () => {
       vi.spyOn(prisma.project, 'findFirst').mockResolvedValue({
         wbsElement: { ...prismaProject1.wbsElement, dateDeleted: new Date() },
         projectId: prismaProject1.projectId
-        //teams: justiceLeague
       } as any);
       await expect(
         async () =>
@@ -319,6 +318,10 @@ describe('Projects', () => {
     });
 
     test('createAssembly fails if name is not unique', async () => {
+      vi.spyOn(prisma.project, 'findFirst').mockResolvedValue({
+        wbsElement: { ...prismaProject1.wbsElement },
+        projectId: prismaProject1.projectId
+      } as any);
       vi.spyOn(prisma.assembly, 'findUnique').mockResolvedValue({ ...prismaAssembly1, name: 'a1' });
 
       // no error, no return value