[17.0][MIG] pricelist_brand: Migration to 17.0 - #314
Open
jarcosmts wants to merge 2 commits into
Open
Conversation
jarcosmts
force-pushed
the
17.0-mig-pricelist_brand
branch
3 times, most recently
from
July 8, 2026 13:31
4c2a62f to
4c4c200
Compare
jarcosmts
force-pushed
the
17.0-mig-pricelist_brand
branch
from
July 8, 2026 13:36
4c4c200 to
a9ac15b
Compare
FrancescoBallerini
suggested changes
Jul 27, 2026
| _inherit = "product.pricelist" | ||
|
|
||
| def _get_applicable_rules_domain(self, products, date, **kwargs): | ||
| res = super()._get_applicable_rules_domain(products, date) |
There was a problem hiding this comment.
**kwargs is missing in super() arguments, should be changed to
res = super()._get_applicable_rules_domain(products, date, **kwargs)
…e_rules_domain Co-authored-by: FrancescoBallerini <FrancescoBallerini@users.noreply.github.com>
Author
|
Thanks for the review! Fixed: **kwargs is now passed through to super()._get_applicable_rules_domain(). |
FrancescoBallerini
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration to 17.0
Based on PR #187 from Studio73
Changes: