[19.0][ADD] website_sale_product_document_type - #1287
Open
Ricardoalso wants to merge 1 commit into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:website_sale_product_document_type
Ricardoalso
marked this pull request as draft
August 14, 2026 13:05
Ricardoalso
changed the title
Ricardoalso
force-pushed
the
website_sale_product_document_type
branch
2 times, most recently
from
August 17, 2026 05:54
2ed3da5 to
2dc5185
Compare
Ricardoalso
marked this pull request as ready for review
August 17, 2026 05:57
Ricardoalso
force-pushed
the
website_sale_product_document_type
branch
from
August 17, 2026 06:05
2dc5185 to
75c669e
Compare
| t-set="product_documents_untyped" | ||
| t-value="product_documents.filtered(lambda d: not d.document_type_id)" | ||
| /> | ||
| <div class="list-group" t-if="product_documents_untyped"> |
There was a problem hiding this comment.
I have reviwed in runbot: untyped documents are displayed immediately below the last typed group, which makes them look like they belong to that document type. Adding an “Other documents” label or simply some spacing before the untyped group would avoid this confusion.
Contributor
Author
There was a problem hiding this comment.
Thanks for your review @dcanete-pyming
Indeed, the current display isn’t very user-friendly. I will add a new label to separate the unlabeled documents
Ricardoalso
force-pushed
the
website_sale_product_document_type
branch
from
August 17, 2026 13:10
75c669e to
48076f5
Compare
Ricardoalso
force-pushed
the
website_sale_product_document_type
branch
from
August 19, 2026 07:36
48076f5 to
650bd6e
Compare
Ricardoalso
force-pushed
the
website_sale_product_document_type
branch
from
August 19, 2026 07:44
650bd6e to
0237d6b
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the e-commerce product page, groups the published product documents by
their document type, showing a heading with the translated type name above
each group. Documents that have no document type are listed together in a
final, unlabelled group.