Skip to content

[18.0][IMP] website_sale_product_brand: add brand microdata - #1290

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-imp-website_sale_product_brand
Aug 18, 2026
Merged

[18.0][IMP] website_sale_product_brand: add brand microdata#1290
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-imp-website_sale_product_brand

Conversation

@pilarvargas-tecnativa

@pilarvargas-tecnativa pilarvargas-tecnativa commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@OCA-git-bot OCA-git-bot added series:18.0 mod:website_sale_product_brand Module website_sale_product_brand labels Aug 17, 2026
carlos-lopez-tecnativa
carlos-lopez-tecnativa reviewed Aug 17, 2026
View reviewed changes

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you could consider adding more information about the brand, such as a description, image, or URL, if any of these fields are set.

@pilarvargas-tecnativa

pilarvargas-tecnativa commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, but you could consider adding more information about the brand, such as a description, image, or URL, if any of these fields are set.

Thanks! Schema.org supports these properties, but google only documents brand.name for product structured data. Since the module has no canonical brand URL, I would keep this PR limited to the brand name.

@pedrobaeza pedrobaeza added this to the 18.0 milestone Aug 18, 2026
carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Aug 18, 2026
View reviewed changes

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza

pedrobaeza commented Aug 18, 2026

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1290-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit d6fd6d1 into OCA:18.0 Aug 18, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 1aa5e85. Thanks a lot for contributing to OCA. ❤️

@carlos-lopez-tecnativa
carlos-lopez-tecnativa deleted the 18.0-imp-website_sale_product_brand branch August 18, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
+1 more reviewer
@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:website_sale_product_brand Module website_sale_product_brand series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pilarvargas-tecnativa @pedrobaeza @OCA-git-bot @carlos-lopez-tecnativa