Skip to content

[18.0][FIX] helpdesk_mgmt: link & subscribe customer partner for unknown senders - #1106

Open
jans23 wants to merge 1 commit into
OCA:18.0from
Nitrokey:18.0-fix-helpdesk_mgmt-unknown-sender-follower
Open

jans23 wants to merge 1 commit into
OCA:18.0from
Nitrokey:18.0-fix-helpdesk_mgmt-unknown-sender-follower

Conversation

@jans23

@jans23 jans23 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Without this fix automatic responses couldn't be sent to emails/tickets being created from senders without partner record.

…ail senders

Without this fix automatic responses couldn't be sent to emails/tickets being
created from senders without partner record.
@jans23
jans23 force-pushed the 18.0-fix-helpdesk_mgmt-unknown-sender-follower branch from 720f343 to 02531f2 Compare September 14, 2026 19:43
)
return res

def _helpdesk_link_and_subscribe_partner(self):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the need for this method or why it's called at the end of message_new() when that method itself calls _mail_find_partner_from_emails() to retrieve the partners and subscribe them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here only To and CC fields are parsed which doesn't catch From when the partner doesn't exist yet. I created a separate method to use it also from website_helpdesk_mgmt which otherwise faces the same issue.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we need to define something like this for the partner_email field: https://github.com/odoo/odoo/blob/434b4e95a6ceca92de21e137911c0b72d7ef7a07/addons/crm/models/crm_lead.py# L100 so that everything works automatically without having to add any extra methods.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how that would solve the issue if no partner record exists. Please elaborate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants