[18.0][FIX] purchase_reception_status: exclude section/note lines from receipt status calculation - #3181
Open
Riv0J wants to merge 3 commits into
Open
[18.0][FIX] purchase_reception_status: exclude section/note lines from receipt status calculation#3181Riv0J wants to merge 3 commits into
Riv0J wants to merge 3 commits into
Conversation
Receipt status calculation is including title/sections, making the resulting value not accurate. Example: when confirming an newly created order with a title/section shows as "partial", because of this line. Should be pending status as it was just confirmed.
Contributor
|
Hi @alexis-via, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module: purchase_reception_status
Receipt status calculation includes section/note lines, making the resulting value inaccurate.
Example: when confirming a newly created order with a title/section it shows as "partial", because of this line.
Should be pending status as it was just confirmed.