Skip to content

[16.0][FIX] tracking_manager: m2m data was tracked as None->None #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
victoralmau wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Draft

[16.0][FIX] tracking_manager: m2m data was tracked as None->None #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tracking_manager/models/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from . import mail_thread
from . import ir_model
from . import models
from . import mail_tracking_value
28 changes: 0 additions & 28 deletions tracking_manager/models/mail_tracking_value.py
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions tracking_manager/tests/test_tracking_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,16 @@ def test_m2m_add_line(self):
self.assertEqual(len(self.messages), 1)
tracking = self.messages.tracking_value_ids
self.assertEqual(len(tracking), 1)
self.assertEqual(tracking.old_value_text, "FOO")
self.assertEqual(tracking.new_value_text, "FOO; BAR")
self.assertEqual(tracking.old_value_char, "FOO")
self.assertEqual(tracking.new_value_char, "FOO, BAR")

def test_m2m_delete_line(self):
self.partner.write({"category_id": [(6, 0, [])]})
self.assertEqual(len(self.messages), 1)
tracking = self.messages.tracking_value_ids
self.assertEqual(len(tracking), 1)
self.assertEqual(tracking.old_value_text, "FOO")
self.assertEqual(tracking.new_value_text, "")
self.assertEqual(tracking.old_value_char, "FOO")
self.assertEqual(tracking.new_value_char, "")

def test_m2m_multi_line(self):
self.partner.write(
Expand All @@ -118,8 +118,8 @@ def test_m2m_multi_line(self):
self.assertEqual(len(self.messages), 1)
tracking = self.messages.tracking_value_ids
self.assertEqual(len(tracking), 1)
self.assertEqual(tracking.old_value_text, "FOO")
self.assertEqual(tracking.new_value_text, "BAR; TOOH")
self.assertEqual(tracking.old_value_char, "FOO")
self.assertEqual(tracking.new_value_char, "BAR, TOOH")

def test_o2m_create_indirectly(self):
self.partner.write({"user_ids": [(0, 0, {"login": "1234567890"})]})
Expand Down