[16.0][ADD] base_module_quick_update: quick upgrade without cascading… - #3682
AntonBalmakov wants to merge 1 commit into
Conversation
c0f6515 to
42a2442
Compare
499dc5a to
8765b3e
Compare
|
CI failure here is unrelated to this change. In the test with Odoo/test with OCB jobs the Install addons and dependencies step aborts before any test runs (Run tests = 0s). Root cause: pip pulls MarkupSafe 3.0.3 (log line 318) while Odoo 16 pins Jinja2 2.11.3 (line 312); Jinja2 2.11.3 imports soft_unicode, removed in MarkupSafe ≥2.1, so import odoo fails and oca_list_external_dependencies reports could not obtain odoo.addons.path. This is a recent environment/wheelhouse regression affecting fresh 16.0 builds, not this PR. A constraint like MarkupSafe<2.1 (CI side) should fix it. Nothing to change here — will re-run once resolved. |
8765b3e to
408209f
Compare
c4a140c to
408209f
Compare
|
Update: all GitHub Actions checks are green on 408209f — pre-commit, "Detect unreleased dependencies", tests with both Odoo and OCB, and codecov (92.94% of the diff covered). The MarkupSafe/Jinja2 problem described above no longer affects the Actions jobs. The only remaining red check is runboat/build, which fails for that same reason on the runboat image side: pip resolves MarkupSafe to 3.0.3 against the pinned Jinja2 2.11.3, so Could a maintainer please take a look? Happy to address any feedback. |
… dependents Adds a Quick upgrade action to ir.module.module that upgrades the selected module only, without cascading to installed modules that depend on it. Missing upstream dependencies are still installed. Task: T0194
408209f to
45aa141
Compare
|
Rebased onto the current 16.0 — all checks are green now, including @pedrobaeza @StefanRijnhart — since you both looked into that same CI issue, would one of you (or any other maintainer) have a moment to review this one? The module adds a Quick upgrade action on |
|
I don't think doing that is a sane one, as the cascade upgrade is something done on purpose for avoiding inconsistencies, so I don't recommend to have this into an OCA module. But if others think it can be useful, I won't block. |
|
Thanks for looking, @pedrobaeza — that's a fair concern, and I agree cascading is the right default. To be clear about the scope: this module doesn't change it. The standard Upgrade button keeps Odoo's behaviour untouched; Quick upgrade is an additional, explicit action restricted to The use case it comes from is development and staging on large databases, where upgrading one module pulls in dozens of dependents and every iteration costs real time. I'm happy to make it explicit rather than implicit:
Would that address your objection? And if any other maintainer has a view on whether this belongs in |
|
Well, I still think it's not a usual use case and the ratio gain/danger is not worth, but as said, others can check it and they would consider it as useful, so you can keep it opened. |
… dependents
Adds a Quick upgrade action to ir.module.module that upgrades the selected module only, without cascading to installed modules that depend on it. Missing upstream dependencies are still installed.
Task: T0194