[15.0][PERF] base_sequence_option: filter options by company in SQL - #3733
Open
Pani-k-folk wants to merge 1 commit into
Open
Pani-k-folk wants to merge 1 commit into
Pani-k-folk wants to merge 1 commit into
Conversation
Contributor
|
Hi @kittiu, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks
When each company has its own sequences,
get_sequence(record)called withoutoptions(assale_order_sequence_option,purchase_order_sequence_option,hr_expense_sequence_optionoraccount_sequence_option._constrains_date_sequencedo)loaded the options of all companies and filtered them in Python, so its cost grew with
the total number of option lines. The company is now filtered in SQL.
10 companies,
get_sequence(record)on 100 journal entries (10 per company), time perrecord:
The remaining cost is the evaluation of each
filter_domainof the record's company,which is unchanged. Same sequence returned for every record.
get_model_options()keepsits signature,
companyis an optional argument.