Release v1.9.1 - #11
Merged
Merged
Conversation
added 2 commits
September 7, 2026 15:41
- Updated `autocomplete` and `similar` methods in `SearchResource` to use `page_size` instead of deprecated `max_suggestions` and `domains` parameters, improving clarity and consistency. - Added `preserve_pagination` option to `perform_post` to retain pagination information in responses. - Enhanced documentation for parameters and updated examples to reflect changes in method signatures. - Improved tests to validate the new parameter mappings and ensure backward compatibility with deprecated aliases.
- Introduced pagination support for similarity search and enhanced response metadata. - Updated autocomplete functionality to utilize `domain_ids` and `page_size`, while maintaining compatibility with previous aliases. - Fixed bugs related to the `include_invalid` parameter in mapping requests and improved documentation for autocomplete responses. - Added `jsonlite` as a test-only dependency and regenerated package manuals to reflect current source.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Reintroduced `page` and `concept_class_ids` parameters in the documentation for clarity. - Enhanced validation in the `similar` method to ensure a single non-missing page value is provided. - Updated tests to confirm the correct handling of pagination and maintain consistency with method signatures.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Changed package version from 1.19.1 to 1.9.1 in DESCRIPTION and NEWS.md files. - Updated tests to reflect the new parameter order in the `similar` method, ensuring consistency with the latest changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Bumps the package to 1.9.1 and aligns
search$similar(),search$autocomplete(), andmappings$map()with the current OMOPHub API. Similarity search now supports pagination, returns the response envelope's metadata, addspage,concept_class_ids, andexclude_selfparameters, and the default algorithm changes fromhybridtosemantic; autocomplete now usespage_sizeanddomain_ids, keeping old arguments as deprecated aliases.Migration
similar()now sendsalgorithm = "semantic"when omitted; passalgorithm = "hybrid"to keep the old behavior.similar()results include apaginationelement; page whilepagination$has_nextis TRUE, andsearch_metadata$totals_are_lower_boundsignals lower-bound totals.domainsandmax_suggestionsstill work but warn when used alongside their replacements.Bug Fixes
mappings$map()now sendsinclude_invalid = FALSEexplicitly, so invalid mappings are excluded as documented.Written for commit 4520bff. Summary will update on new commits.