Remove OptionalPlaceHolders on NodeState Instances#3573
Merged
Conversation
romanett
reviewed
May 6, 2026
| private static bool IsPlaceholderChild(BaseInstanceState child) | ||
| { | ||
| if (child.ModellingRuleId == ObjectIds.ModellingRule_OptionalPlaceholder || | ||
| child.ModellingRuleId == ObjectIds.ModellingRule_MandatoryPlaceholder) |
Contributor
There was a problem hiding this comment.
why remove MandatoryPlaceholder?
Contributor
Author
There was a problem hiding this comment.
Because it is still a place holder declaration not a concrete runtime instance that should not appear as a concrete child in a runtime instance.
Contributor
Author
Contributor
There was a problem hiding this comment.
@mrsuciu okay, so this restores the behaviour from before 1.5.378? Because Else i would think it could Break Adress spaces of Users that expect those placeholders
Contributor
Author
There was a problem hiding this comment.
@romanett These placeholders should not exist on the instances, just on the declarations which are part of Types
…aving type-definition trees untouched.
mrsuciu
force-pushed
the
noOptionalPlaceholders
branch
from
94bc964 to
bd2c63d
Compare
romanett
approved these changes
May 12, 2026
romanett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Test that Optional place holders are not present in node state instancesNo optional placeholderse.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...