Skip to content

GH-360: I removed the code in tidy-warnings#361

Merged
jgallagher59701 merged 1 commit into
masterfrom
jhrg/gh-360-sscan-issue
Jul 14, 2026
Merged

GH-360: I removed the code in tidy-warnings#361
jgallagher59701 merged 1 commit into
masterfrom
jhrg/gh-360-sscan-issue

Conversation

@jgallagher59701

Copy link
Copy Markdown
Member

There was some old python code that was used to edit source files and a LLM (i.e., agentic AI) could use it in ways that pose a security threat. It was no longer used, so I removed it.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0426ae42-e38a-43dc-a499-cb5c87038cfb

📥 Commits

Reviewing files that changed from the base of the PR and between b15a4d0 and 2f03c7c.

📒 Files selected for processing (5)
  • tidy-warnings/README.md
  • tidy-warnings/apply_overrides.py
  • tidy-warnings/extract-warnings.py
  • tidy-warnings/remove_redundant_virtual.py
  • tidy-warnings/warnings_1.txt
💤 Files with no reviewable changes (5)
  • tidy-warnings/README.md
  • tidy-warnings/extract-warnings.py
  • tidy-warnings/warnings_1.txt
  • tidy-warnings/remove_redundant_virtual.py
  • tidy-warnings/apply_overrides.py

📝 Walkthrough
  • Removed unused tidy-warnings Python scripts and documentation.
  • Removed stale warning entries.
Author Lines added Lines removed
James Gallagher 0 482

Walkthrough

The pull request removes the tidy-warnings documentation and three Python warning-fixing utilities, and deletes obsolete warning entries from warnings_1.txt.

Changes

Tidy-warnings removal

Layer / File(s) Summary
Remove warning-fixing utilities and documentation
tidy-warnings/README.md, tidy-warnings/apply_overrides.py, tidy-warnings/extract-warnings.py, tidy-warnings/remove_redundant_virtual.py
The documentation and scripts for extracting warnings, adding override, and removing redundant virtual keywords were deleted.
Remove obsolete warning data
tidy-warnings/warnings_1.txt
Warning entries for methods in libdap4/Structure.h and libdap4/Sequence.h were removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Poem

A bunny found scripts in a dusty burrow,
And cleared old warnings without any sorrow.
The tools hopped away, the logs disappeared,
No redundant keywords remained to be feared.
“Clean code!” cried the rabbit, ears held high.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing the tidy-warnings code.
Description check ✅ Passed The description is directly related to the change and explains why the unused code was removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jhrg/gh-360-sscan-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@jgallagher59701
jgallagher59701 marked this pull request as ready for review July 14, 2026 12:24
@jgallagher59701

Copy link
Copy Markdown
Member Author

No issues remain.
Screenshot 2026-07-14 at 1 24 10 PM

@jgallagher59701
jgallagher59701 merged commit 2aff856 into master Jul 14, 2026
8 checks passed
@jgallagher59701
jgallagher59701 deleted the jhrg/gh-360-sscan-issue branch July 14, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants