Require a positive sample count in the equilibration pressure integation - #7347
Merged
Conversation
GitPaean
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
bska
reviewed
Aug 24, 2026
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
This is very late detection. I think I'd prefer that we move the check to where we load the value, in FlowGenericProblem's constructor, where we have more context and can provide a better diagnostic message.
GitPaean
force-pushed
the
rk4ivp_precondition
branch
from
August 24, 2026 08:19
f52b78f to
f1fd1ac
Compare
RK4IVP divides by the sample count and evaluates interval N - 1, so a zero was a division by zero instead of an input error. Check it in FlowGenericProblem where the value is read, naming EQLDIMS item 2 or --num-pressure-points-equil as its source.
Member
Author
|
jenkins build this please |
bska
approved these changes
Aug 24, 2026
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the updates. This looks good to me and I'll merge into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RK4IVP divides by the sample count and evaluates interval N - 1, so a zero from EQLDIMS item 2 or --num-pressure-points-equil was a division by zero instead of an input error.
It is raised by the copilot in #7306