Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates OSDCloud launch workflows to align with the new deployment structure by renaming invocation targets (CLI/GUI/Dev/Azure) and relocating the Azure start entry point into its own public function file.
Changes:
- Update CLI/GUI/Dev launchers to call the new
Invoke-OSDCloud*function variants (Invoke-OSDCloudCLI,Invoke-OSDCloudGUI,Invoke-OSDCloudGUIDev). - Move
Start-OSDCloudAzureout ofConnect-OSDCloudAzure.ps1into a dedicated public function file. - Add new private entry points
Invoke-OSDCloudGUIandInvoke-OSDCloudAzure(large task-sequence implementations).
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Public/Start-OSDCloudCLI.ps1 | Updates messaging and the final handoff call to Invoke-OSDCloudCLI. |
| Public/Start-OSDCloudAzure.ps1 | Introduces the new Azure start function and handoff to Invoke-OSDCloudAzure. |
| Public/OSDCloud/Connect-OSDCloudAzure.ps1 | Removes the embedded Start-OSDCloudAzure function after relocation. |
| Projects/OSDCloudGUI/MainWindow.ps1 | Updates GUI start button to call Invoke-OSDCloudGUI. |
| Projects/OSDCloudDev/MainWindow.ps1 | Updates Dev GUI start button to call Invoke-OSDCloudGUIDev. |
| Private/Invoke-OSDCloudGUI.ps1 | Adds the GUI-specific master task sequence implementation. |
| Private/Invoke-OSDCloudAzure.ps1 | Adds the Azure-specific master task sequence implementation. |
Comment on lines
+21
to
+29
| .NOTES | ||
| Author: David Segura - Recast Software | ||
| 2026-07-10 - Updated help to repo standard | ||
|
|
||
| .LINK | ||
| https://github.com/OSDeploy/OSD/tree/master/docs | ||
|
|
||
| .LINK | ||
| https://github.com/OSDeploy/OSD/blob/master/docs/Start-OSDCloudAzure.md |
Comment on lines
+9
to
+10
| .EXAMPLE | ||
| Invoke-OSDCloud |
Comment on lines
+58
to
+66
| if ($Global:StartOSDCloud.AzOSDCloudImage) { | ||
| Write-Host -ForegroundColor DarkGray '=========================================================================' | ||
| Write-Host -ForegroundColor Green "Invoke-OSDCloudAzure ... Starting in 5 seconds..." | ||
| Start-Sleep -Seconds 5 | ||
| Invoke-OSDCloudAzure | ||
| } | ||
| else { | ||
| Write-Warning "Unable to get a Windows Image from OSDCloudAzure to handoff to Invoke-OSDCloudAzure" | ||
| } |
Comment on lines
+9
to
+10
| .EXAMPLE | ||
| Invoke-OSDCloud |
Comment on lines
+2549
to
+2552
| foreach ($Item in $AzOSDCloudPostScript) { | ||
| Write-DarkGrayHost "$($Item.FullName)" | ||
| & "Execute $($Item.FullName)" | ||
| } |
Comment on lines
+2549
to
+2552
| foreach ($Item in $AzOSDCloudPostScript) { | ||
| Write-DarkGrayHost "$($Item.FullName)" | ||
| & "Execute $($Item.FullName)" | ||
| } |
| } | ||
| # UUID | ||
| $deviceUUID = $classWin32ComputerSystemProduct.UUID | ||
| # Convert the UUID to a hash value to protect user privacyand ensure a consistent identifier across events |
| } | ||
| # UUID | ||
| $deviceUUID = $classWin32ComputerSystemProduct.UUID | ||
| # Convert the UUID to a hash value to protect user privacyand ensure a consistent identifier across events |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update function names and references to align with the new OSDCloud deployment structure, ensuring consistency across the codebase. The changes include renaming scripts and updating the invocation methods for better clarity and functionality.