Upgrade to Java 21#903
Closed
vasiliy-mikhailov wants to merge 1 commit into
Closed
Conversation
Raise the maven-compiler-plugin release from 17 to 21 and bump the CI/release workflow JDK to match. All 162 unit tests pass under JDK 21 with none lost.
0126327 to
05ec2c1
Compare
Author
|
Closing this out — on reflection a standalone Java-version bump isn't really worth your review time without a clear benefit, and I didn't want to leave it sitting in your queue. Thanks for the work on this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the build from Java 17 to Java 21 (current LTS).
pom.xml:maven-compiler-plugin<release>17 → 21.github/workflows/test.yml&release.yml:java-version17 → 21, so CI builds on the new target (otherwise the JDK-17 runners can't compile a release-21 build)Verification: the project compiles under JDK 21 and all 162 unit tests pass, with none lost versus the JDK-17 baseline. Integration tests that need external services (MongoDB/MariaDB/Docker) were not run locally and are unchanged. No production or test code was modified — only the compiler target and the CI JDK.
How this was produced
The compiler-target change was produced with OpenRewrite's
UpgradeJavaVersionrecipe:mvn -U org.openrewrite.maven:rewrite-maven-plugin:RELEASE:run \ -Drewrite.configLocation=$(pwd)/rewrite.yml \ -Drewrite.activeRecipes=com.example.UpgradeJava \ -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASEThe diff was then reduced by hand to the minimal compiler-target change, and the CI workflow
java-versionwas updated to match (OpenRewrite does not edit GitHub Actions).Verified: all 162 tests pass under JDK 21, none lost versus the baseline.