core: dedup fetch contrib#4536
Closed
pinebit wants to merge 2 commits into
Closed
Conversation
pinebit
added
the
do not merge
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4536 +/- ##
==========================================
+ Coverage 57.01% 57.14% +0.13%
==========================================
Files 245 245
Lines 32971 33069 +98
==========================================
+ Hits 18799 18898 +99
- Misses 11789 11790 +1
+ Partials 2383 2381 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added BN-response deduplication to
fetchContributionDataincore/fetcher/fetcher.go. The change cachesSyncCommitteeContributionresponses by(slot, subcommitteeIndex, beaconBlockRoot)so that multiple cluster validators that fall in the same subcommittee share one BN call instead of N.Confirmed with teku-teku combo run in AWS. Next is to confirm the fix with all the combos.
category: refactor
ticket: none