fix: 336 - make audience ref#339
Closed
ben-wilson-mews wants to merge 1 commit into
Closed
Conversation
submit audience as null to api instead of “”, matching UI behavior
|
|
Author
|
Hey @denys-octopus @APErebus , it looks like you're the most active maintainers on here. Would it be possible to get some 👀 on this when you get a moment please? |
alexrudd
reviewed
Jun 5, 2026
alexrudd
left a comment
alexrudd
left a comment
There was a problem hiding this comment.
We've also just hit this problem in migrating to using OICD accounts for our integration with GitHub actions
| Name string `json:"Name"` | ||
| ServiceAccountID string `json:"ServiceAccountId"` | ||
| Subject string `json:"Subject"` | ||
| Audience *string `json:"Audience"` |
There was a problem hiding this comment.
Looking at some of the other API structs in the repo, I think using omitempty would be more consistent.
Suggested change
| Audience *string `json:"Audience"` | |
| Audience string `json:"Audience,omitempty"` |
Contributor
|
This has been fixed in #422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#338
Make audience a ref. I can't see any usage, getters or setters in the codebase. So provided it passes the tests we should be good.
This is a blocker for adopting the terraform provider as it's currently none functional for deploying OIDC on service accounts