Skip to content

Fix empty GitDependencyName being cleared in Channel DeploymentActionGitDependency#424

Merged
N-lson merged 1 commit into
mainfrom
nelson/action-git-dependency
Jun 15, 2026
Merged

Fix empty GitDependencyName being cleared in Channel DeploymentActionGitDependency#424
N-lson merged 1 commit into
mainfrom
nelson/action-git-dependency

Conversation

@N-lson

@N-lson N-lson commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This property is Required(AllowEmptyStrings = true) in Octopus, meaning empty strings are an accepted value. omitempty caused this value to be cleared when an empty string was used as the value, leading to the following error from Octopus (example usage from the Terraform provider):

Octopus API error: There was a problem with your request. [The GitDependencyName field is required.]

This PR also updates DeploymentActionSlug to be required as this is also a required property in Octopus (however this one can't be empty).

…entActionSlug in DeploymentActionGitDependency

@clairey259 clairey259 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test coverage.

@N-lson N-lson merged commit 346d538 into main Jun 15, 2026
6 checks passed
@N-lson N-lson deleted the nelson/action-git-dependency branch June 15, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants