Dashboard v0.2.2 — login-screen versions, and drop frame-ancestors - #10
Merged
Conversation
The strict CSP injected into the built index.html carried `frame-ancestors 'none'`, which is only honoured in a real HTTP header, never in a <meta> tag — and GitHub Pages does not let us set headers. It bought no protection and logged a console error on every page load. The directive was removed from the deploy workflow in the v0.15.0 work; this bumps the dashboard so the gated Pages deploy actually ships it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add `omnyServerWebVersion` (lib/version.dart), synced to pubspec.yaml by a test, and compose it with the omnyserver package version the dashboard was built against into a single `versionLabel`. The login screen shows that line under the form — `Dashboard v0.2.2 · OmnyServer v0.15.0`. Both halves are compile-time: at the login screen there is no Hub connection yet, so the line names the API the dashboard targets, not the version of the Hub you go on to sign in to. The tooltip says so; that caveat is the one bit local to the login screen, so it stays there while the text itself is centralized. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gmpassos
changed the title
Use the stylesheet's purpose-built `.version-footer` (text-align: center) rather than a one-off inline style. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two dashboard changes, shipped together as 0.2.2 so the gated Pages deploy fires once.
Login-screen versions
The login screen now shows a version line under the form:
omnyServerWebVersion(lib/version.dart), kept in sync withpubspec.yamlby a test — mirroring the server'somnyServerVersion/version_test.dart.omnyserverpackage version the dashboard was built against (the deploy path-overridesomnyserverto this repo, so the two always match).versionLabelinlib/version.dart; the screen just renders it.Verified the dart2js release build (what the deploy runs): the bundle compiles and both
Dashboard v0.2.2andOmnyServer v0.15.0are baked in.Drop
frame-ancestorsfrom the CSPThe v0.15.0 work removed
frame-ancestorsfrom the CSP thatdeploy.ymlinjects intoindex.html— it's only honoured in a real HTTP header, never in a<meta>tag, so it did nothing but log a console error on every page load. But the Pages deploy is gated on a dashboard version bump, and those PRs were server-only, so the fix never went live. This bump carries it.Every other CSP directive is unchanged.
🤖 Generated with Claude Code