Skip to content

Foundation: Replaces libsass with dart sass binary#2511

Open
cyrillkuettel wants to merge 4 commits into
masterfrom
ogc-3071-libsass
Open

Foundation: Replaces libsass with dart sass binary#2511
cyrillkuettel wants to merge 4 commits into
masterfrom
ogc-3071-libsass

Conversation

@cyrillkuettel
Copy link
Copy Markdown
Contributor

@cyrillkuettel cyrillkuettel commented Jun 3, 2026

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Foundation: Replaces libsass with dart sass binary

Dart Sass is the primary implementation of Sass,

TYPE: Feature
LINK: OGC-3071

Checklist

  • I have performed a self-review of my code
  • I have tested my code thoroughly by hand

@linear
Copy link
Copy Markdown

linear Bot commented Jun 3, 2026

OGC-3071

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2695 1 2694 17
View the top 1 failed test(s) by shortest run time 
tests/onegov/pas/test_views.py::test_abschluss_email_uses_commission_name
Stack Traces | 2.69s run time 
client = <tests.shared.client.Client object at 0x7fe550da97f0>

    def test_abschluss_email_uses_commission_name(
        client: Client[TestPasApp],
    ) -> None:
        client.login_admin()
        settings = client.get('/').follow().click('PAS Einstellungen')
        add_rate_set(settings, [])
    
        session = client.app.session()
        session.add(
            SettlementRun(
                name='Q1 2024',
                start=datetime.date(2024, 1, 1),
                end=datetime.date(2024, 12, 31),
                active=True,
                closed=False,
            )
        )
    
        parliamentarians = PASParliamentarianCollection(client.app)
        parl = parliamentarians.add(
            first_name='Max',
            last_name='Muster',
            email_primary='max.muster@example.org',
        )
    
        session.add(PASParliamentarianRole(
            parliamentarian_id=parl.id,
            role='member',
            start=datetime.date(2024, 1, 1),
            meta={'org_type': 'Kantonsrat'},
        ))
    
        commissions = PASCommissionCollection(session)
        commission = commissions.add(name='Finanzkommission')
    
        PASCommissionMembershipCollection(session).add(
            commission_id=commission.id,
            parliamentarian_id=parl.id,
            role='member',
            start=datetime.date(2024, 1, 1),
        )
    
        session.flush()
        transaction.commit()
    
        # Create attendance without abschluss first
        page = (
            client.get('/')
            .follow()
            .click('Anwesenheiten')
            .click(href='new', index=0)
        )
        page.form['date'] = '2024-06-15'
        page.form['duration'] = '2'
        page.form['type'] = 'commission'
        page.form['commission_id'].select(text='Finanzkommission')
        page.form['parliamentarian_id'].select(text='Max Muster')
        page.form['abschluss'] = False
        page = page.form.submit().follow()
    
        # Now edit to set abschluss — this triggers the email
        page = page.click('Bearbeiten')
        page.form['abschluss'] = True
        page.form.submit().follow()
    
        email = client.get_email(0)
        assert email['Subject'] == ('PAS: Abschluss gesetzt für Finanzkommission')
        assert 'Finanzkommission' in email['HtmlBody']
>       assert 'Max Muster' in email['HtmlBody']
E       assert 'Max Muster' in '\n<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3..../xhtml1/DTD/xhtml1-transitional...>\n                </div>\n            </td>\n            <td></td>\n        </tr>\n    </table>\n</body>\n</html>\n\n'

.../onegov/pas/test_views.py:1309: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cyrillkuettel