Fixes SDL3 Ubuntu test and Flatpak build#653
Merged
Merged
Conversation
mcarans
changed the title
phkb
approved these changes
May 23, 2026
Contributor
phkb
left a comment
phkb
left a comment
There was a problem hiding this comment.
This is fine with me, but all I can do is validate the Windows build works correctly.
kanthoney
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu 26.04 has not been released as a GitHub runner, so using a container to get it.
SDL3 has an offscreen driver mode which means that using xwfb-run and all the Wayland software driver stuff isn't needed, a nice improvement.
Flatpak requires building SDL3 to get 3.4 (3.2 is the default).
The Flatpak YAML version stuff is more robust as it is now linked to a comment rather than a specific line number