Skip to content

classifier: Handle invalid page mapping #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbaldyga merged 1 commit into from
Jun 29, 2026
Merged

classifier: Handle invalid page mapping #1776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions modules/cas_cache/classifier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ static cas_cls_eval_t _cas_cls_metadata_test(struct cas_classifier *cls,
struct cas_cls_condition *c, struct cas_cls_io *io,
ocf_part_id_t part_id)
{
struct address_space *mapping;

if (!io->page)
return cas_cls_eval_no;

Expand All @@ -62,9 +64,10 @@ static cas_cls_eval_t _cas_cls_metadata_test(struct cas_classifier *cls,
return cas_cls_eval_yes;
}

if (!cas_page_mapping(io->page)) {
/* XFS case, page are allocated internally and do not
* have references into inode
mapping = cas_page_mapping(io->page);
if (!mapping || !virt_addr_valid(mapping)) {
/* XFS case: page is allocated internally without a page
* cache mapping.
*/
return cas_cls_eval_yes;
}
Expand Down Expand Up @@ -1284,6 +1287,9 @@ static void _cas_cls_get_bio_context(struct bio *bio,
if (!mapping)
return;

if (!virt_addr_valid(mapping))
return;

ctx->inode = mapping->host;

return;
Expand Down
Loading