fix(hotkeys): support F13–F20 and the native Mac Dictation key - #1040
Merged
H-Chris233 merged 4 commits intoSep 9, 2026
Merged
Conversation
Eclock2000
marked this pull request as ready for review
September 8, 2026 01:01
Eclock2000
marked this pull request as draft
September 8, 2026 01:03
H-Chris233
marked this pull request as ready for review
September 9, 2026 05:01
H-Chris233
reviewed
Sep 9, 2026
H-Chris233
left a comment
Collaborator
There was a problem hiding this comment.
首轮静态审核,基于 4a7c715
已检查扩展功能键校验和平台映射、Mac 原生键事件状态机、设置事务切换以及侧向修饰键监听器回滚路径
保留原绑定直到替代注册成功,以及回滚时复用 side-aware sender,是这次改动中需要继续保留的行为
当前不能给出合并批准
该提交关联 CI run 34183009905 的 conclusion 为 action_required,查询返回 jobs 为空,不能把 PR 描述中的本地验证当作当前 GitHub CI 已通过
合并前建议补充三组验证
• 在集成后的 beta 应用内验证按住、切换式录音、文本插入和重启后的持久化绑定,同时覆盖普通 F5、F20、Fn 组合键及 Secure Event Input
• 针对 native → 普通组合键、侧向组合键 → native 的注册失败与配置持久化失败,验证旧监听器仍能实际发出 press/release,而不仅是偏好值回滚
• macos_dictation_key.rs 的 callback 收到 event-tap-disabled 后发送 Released、设置 stop=true 并只写日志,请补充该路径的应用级测试,尤其是切换式录音已经开始时能否结束,以及用户如何发现监听器失效并重新启用,不能仅验证 KeyState
还需补充 Windows 实际键盘的 F13 至 F20 验证
以上是首轮审查与待验证事项,没有声称完成真机复现,也没有运行本地完整构建
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support F13–F20 and add the native Mac microphone/Dictation key to the existing dictation shortcut menu. Selecting it replaces the current binding; there is still one dictation trigger.
Changes
The native option requires a compatible Mac keyboard and Accessibility permission. There is no setup wizard, extra trigger, saved fallback binding, status polling, or dedicated retry UI. The shared preference schema and hotkey event loops are unchanged.
Validation
npm run tauri -- build --bundles app;codesign --verify --deep --strict).Integrated beta recording/text insertion, restart behavior, and Windows hardware behavior have not been manually verified. These limitations are disclosed for review; the earlier hardware checks are not full beta application acceptance.