Skip to content

Sanitize partner Message-ID used as inbound payload filename fallback #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uhurusurfa merged 2 commits into from
Jul 25, 2026
Merged

Sanitize partner Message-ID used as inbound payload filename fallback #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84ee533
Sanitize partner Message-ID used as inbound payload filename fallback
JakeHuneau Jul 18, 2026
744e623
Restore as2_certs.p12 to the master version
JakeHuneau Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Server/src/main/java/org/openas2/processor/receiver/AS2ReceiverHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import java.util.Enumeration;
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;

public class AS2ReceiverHandler implements NetModuleHandler {
private AS2ReceiverModule module;
Expand Down Expand Up @@ -216,7 +217,15 @@ public void handle(NetModule owner, Socket s) {
if (filename == null || filename.length() == 0) {
filename = Properties.getProperty(Properties.AS2_RX_MESSAGE_FILENAME_FALLBACK, null);
if (filename == null) {
filename = msg.getMessageID();
// The Message-ID is partner-controlled, so sanitise it before using
// it as a filename to avoid path traversal. Fall back to a safe
// generated name if it cannot be made safe.
try {
filename = IOUtil.getSafeFilename(msg.getMessageID());
} catch (OpenAS2Exception e) {
filename = "received-" + UUID.randomUUID();
LOG.warn("Message-ID is not usable as a safe filename (" + e.getMessage() + "); using generated name: " + filename);
}
} else {
CompositeParameters parser = new CompositeParameters(false).add("date", new DateParameters()).add("msg", new MessageParameters(msg)).add("rand", new RandomParameters());
filename = ParameterParser.parse(filename, parser);
Expand Down
Loading